harikrishna-patnala commented on PR #9659: URL: https://github.com/apache/cloudstack/pull/9659#issuecomment-2516559746
> > @DaanHoogland, before merging this one, please check #8605. > > This PR solves the same thing that #8605, but apparently that solution was ignored. > > ok @GutoVeronezi (and @harikrishna-patnala) , please discuss whether to merge or choose one of the two? > > As far as I can see the main difference is whether the configuration is done in a Configitem or in a separate table, is that right? Thanks @GutoVeronezi for bringing this up. I wasn't aware of your earlier PR, so I independently worked on a solution to address this issue, which is now available here. Yes @DaanHoogland both the solutions aim to resolve the same problem, though with slightly different approaches one with global setting and one with database table. I feel the current PR offers a more user-friendly experience and is already accessible through the UI. Additionally, it has gone through the development cycle, including reviews, testing, and validation, and is now ready to merge. That said, @GutoVeronezi I want to ensure that any valuable aspects of your earlier work are not overlooked. If there are specific elements from your solution that you feel should be incorporated here, I'd be happy to discuss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
