DaanHoogland commented on issue #9983:
URL: https://github.com/apache/cloudstack/issues/9983#issuecomment-2517338750

   > > @rohityadavcloud @JoaoJandre is there a use case for not upgrading the 
log4j.xml? It reads to me like it should always be upgraded.
   > 
   > It should always be upgraded, otherwise the logging will not work, as 
@rohityadavcloud experienced. However, we might not want to forcefully 
substitute the old file with a new one. The user might want to manually upgrade 
their file, if they have made changes to it, for example. I think that having 
it on the release notes and having it be asked on install is enough. I'm not 
sure what else we should do.
   
   I think we can reverse the procedure;
   - make a copy of the old file
   - replace it
   - document that the user needs to re-incorporate their changes
   
   (no hard demand, but it seems better given Rohit's experience)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to