sureshanaparti commented on code in PR #10017:
URL: https://github.com/apache/cloudstack/pull/10017#discussion_r1871060030
##########
server/src/main/java/com/cloud/configuration/Config.java:
##########
@@ -1415,6 +1447,8 @@ public enum Config {
DefaultMaxDomainPublicIPs("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.public.ips", "40", "The default maximum number of
public IPs that can be consumed by a domain", null),
DefaultMaxDomainTemplates("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.templates", "40", "The default maximum number of
templates that can be deployed for a domain", null),
DefaultMaxDomainSnapshots("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.snapshots", "40", "The default maximum number of
snapshots that can be created for a domain", null),
+ DefaultMaxDomainBackups("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.backups", "-1", "The default maximum number of backups
that can be created for a domain", null),
+ DefaultMaxDomainBackupStorage("Domain Defaults", ManagementServer.class,
Long.class, "max.domain.backup.storage", "-1", "The default maximum backup
storage space (in GiB) that can be used for a domain", null),
Review Comment:
better keep some limit for domain backup & storage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
