BryanMLima commented on PR #10052: URL: https://github.com/apache/cloudstack/pull/10052#issuecomment-2528986544
> @BryanMLima this works in Dutch, so far for the good news. Now I have my doubts about the implementation. As the account type is a logic element of the system I would expect it to be the symbol 'Account' or the symbol 'Project' and not the english or other language words. I would expect the `selectedAccountType` to be compared to the symbols. What is the reason you choose for this implementation? @DaanHoogland, I agree with you, we should not use translation of a label to the logic of the code. I made some changes to the components that are using the `OwnershipSelection`. With these changes, I tested the creating VMs, Isolated networks, L2 networks, shared FS and volumes; all resources were created accordingly to the owner specified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
