DaanHoogland commented on code in PR #9925:
URL: https://github.com/apache/cloudstack/pull/9925#discussion_r1895700027
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##########
@@ -459,7 +466,7 @@ private void prepareHost(HostMO hostMo, String
privateTrafficLabel) throws Excep
AboutInfo about = hostMo.getHostAboutInfo();
if (about != null) {
String version = about.getApiVersion();
- if (version != null && (version.equals("4.0") ||
version.equals("4.1")) && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x) {
+ if (version != null && (version.equals("4.0") ||
version.equals("4.1")) ) { // && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x)
Review Comment:
`_portsPerDvPortGroup < DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x)` comes
down to the hardcoded condition `8<256`
```suggestion
if (version != null && (version.equals("4.0") ||
version.equals("4.1")) ) { // && _portsPerDvPortGroup <
DEFAULT_PORTS_PER_DV_PORT_GROUP_VSPHERE4_x), which means 8 < 256
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
