sureshanaparti commented on code in PR #9873:
URL: https://github.com/apache/cloudstack/pull/9873#discussion_r1900087088
##########
server/src/main/java/org/apache/cloudstack/network/RoutedIpv4ManagerImpl.java:
##########
@@ -962,10 +962,10 @@ public boolean applyRoutingFirewallRule(long id) {
return false;
}
if (!FirewallRule.Purpose.Firewall.equals(rule.getPurpose())) {
- logger.error(String.format("Cannot apply routing firewall rule
with ID: %d as purpose %s is not %s", id, rule.getPurpose(),
FirewallRule.Purpose.Firewall));
+ logger.error("Cannot apply routing firewall rule: {} as purpose {}
is not {}", rule, rule.getPurpose(), FirewallRule.Purpose.Firewall);
return false;
}
- logger.debug(String.format("Applying routing firewall rules for rule
with ID: %s", rule.getUuid()));
+ logger.debug("Applying routing firewall rules for rule with ID: {}",
rule);
Review Comment:
```suggestion
logger.debug("Applying routing firewall rules for rule: {}", rule);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
