sureshanaparti commented on code in PR #9873:
URL: https://github.com/apache/cloudstack/pull/9873#discussion_r1900154279
##########
server/src/main/java/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java:
##########
@@ -521,14 +520,14 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
}
@DB
- private boolean removeVpnUserWithoutRemoteAccessVpn(long vpnOwnerId,
String userName) {
- VpnUserVO vpnUser = _vpnUsersDao.findByAccountAndUsername(vpnOwnerId,
userName);
+ private boolean removeVpnUserWithoutRemoteAccessVpn(Account vpnOwner,
String userName) {
+ VpnUserVO vpnUser =
_vpnUsersDao.findByAccountAndUsername(vpnOwner.getId(), userName);
if (vpnUser == null) {
- logger.error(String.format("VPN user not found with ownerId: %d
and username: %s", vpnOwnerId, userName));
+ logger.error("VPN user not found with owner: {} and username: {}",
vpnOwner, userName);
return false;
}
if (!State.Revoke.equals(vpnUser.getState())) {
- logger.error(String.format("VPN user with ownerId: %d and
username: %s is not in revoked state, current state: %s", vpnOwnerId, userName,
vpnUser.getState()));
+ logger.error("VPN user with ownerId: {} and username: {} is not in
revoked state, current state: {}", vpnOwner, userName, vpnUser.getState());
Review Comment:
```suggestion
logger.error("VPN user with owner: {} and username: {} is not in
revoked state, current state: {}", vpnOwner, userName, vpnUser.getState());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
