DaanHoogland commented on PR #10237:
URL: https://github.com/apache/cloudstack/pull/10237#issuecomment-2607639556
Did some more research, @harikrishna-patnala . at least these changes are
needed as well (still looking)
```
diff --git
a/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsDaoImpl.java
b/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsDaoImpl.java
index 70aaf91c6ae..37e10910978 100644
--- a/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsDaoImpl.java
+++ b/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsDaoImpl.java
@@ -43,11 +43,11 @@ public class ClusterDetailsDaoImpl extends
ResourceDetailsDaoBase<ClusterDetails
protected ClusterDetailsDaoImpl() {
ClusterSearch = createSearchBuilder();
- ClusterSearch.and("clusterId",
ClusterSearch.entity().getClusterId(), SearchCriteria.Op.EQ);
+ ClusterSearch.and("clusterId",
ClusterSearch.entity().getResourceId(), SearchCriteria.Op.EQ);
ClusterSearch.done();
DetailSearch = createSearchBuilder();
- DetailSearch.and("clusterId", DetailSearch.entity().getClusterId(),
SearchCriteria.Op.EQ);
+ DetailSearch.and("clusterId",
DetailSearch.entity().getResourceId(), SearchCriteria.Op.EQ);
DetailSearch.and("name", DetailSearch.entity().getName(),
SearchCriteria.Op.EQ);
DetailSearch.done();
}
diff --git a/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsVO.java
b/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsVO.java
index 810fff2851f..3e00b5c0310 100644
--- a/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsVO.java
+++ b/engine/schema/src/main/java/com/cloud/dc/ClusterDetailsVO.java
@@ -35,7 +35,7 @@ public class ClusterDetailsVO implements ResourceDetail {
private long id;
@Column(name = "cluster_id")
- private long clusterId;
+ private long resourceId;
@Column(name = "name")
private String name;
@@ -47,18 +47,18 @@ public class ClusterDetailsVO implements ResourceDetail {
}
public ClusterDetailsVO(long clusterId, String name, String value) {
- this.clusterId = clusterId;
+ this.resourceId = clusterId;
this.name = name;
this.value = value;
}
public long getClusterId() {
- return clusterId;
+ return resourceId;
}
@Override
public long getResourceId() {
- return clusterId;
+ return resourceId;
}
public String getName() {
```
I suspect similar things need to be done for the other details record types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
