abh1sar commented on code in PR #10232:
URL: https://github.com/apache/cloudstack/pull/10232#discussion_r1928133158


##########
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##########
@@ -850,6 +850,10 @@ protected boolean lockAccount(long accountId) {
     public boolean deleteAccount(AccountVO account, long callerUserId, Account 
caller) {
         long accountId = account.getId();
 
+        if (account.getState() != State.DISABLED) {

Review Comment:
   removed unit tests. rebased to 4.19 : 
https://github.com/apache/cloudstack/pull/10242



##########
server/src/main/java/com/cloud/user/AccountManagerImpl.java:
##########
@@ -850,6 +850,10 @@ protected boolean lockAccount(long accountId) {
     public boolean deleteAccount(AccountVO account, long callerUserId, Account 
caller) {
         long accountId = account.getId();
 
+        if (account.getState() != State.DISABLED) {

Review Comment:
   @weizhouapache  removed unit tests. rebased to 4.19 : 
https://github.com/apache/cloudstack/pull/10242



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to