BryanMLima commented on code in PR #10237:
URL: https://github.com/apache/cloudstack/pull/10237#discussion_r1931176758
##########
engine/schema/src/main/java/org/apache/cloudstack/resourcedetail/ResourceDetailsDaoBase.java:
##########
@@ -201,4 +210,13 @@ public List<Long> findResourceIdsByNameAndValueIn(String
name, Object[] values)
return customSearch(sc, null);
}
+
+ @Override
+ public String getActualValue(ResourceDetail resourceDetail) {
+ ConfigurationVO configurationVO =
_configDao.findByName(resourceDetail.getName());
Review Comment:
```suggestion
ConfigurationVO configurationVO =
configDao.findByName(resourceDetail.getName());
```
##########
engine/schema/src/main/java/org/apache/cloudstack/resourcedetail/ResourceDetailsDaoBase.java:
##########
@@ -28,8 +29,16 @@
import com.cloud.utils.db.SearchCriteria;
import com.cloud.utils.db.TransactionLegacy;
import com.cloud.utils.db.SearchCriteria.Op;
+import org.apache.cloudstack.framework.config.dao.ConfigurationDao;
+import org.apache.cloudstack.framework.config.impl.ConfigurationVO;
+
+import javax.inject.Inject;
public abstract class ResourceDetailsDaoBase<R extends ResourceDetail> extends
GenericDaoBase<R, Long> implements ResourceDetailsDao<R> {
+
+ @Inject
+ private ConfigurationDao _configDao;
Review Comment:
```suggestion
private ConfigurationDao configDao;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
