Pearl1594 commented on code in PR #9561:
URL: https://github.com/apache/cloudstack/pull/9561#discussion_r1956245278
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/version/KubernetesVersionManagerImpl.java:
##########
@@ -160,6 +164,33 @@ private List <KubernetesSupportedVersionVO>
filterKubernetesSupportedVersions(Li
return versions;
}
+ private GetUploadParamsResponse
registerKubernetesVersionIsoForUpload(final Long zoneId, final String
versionName, final String isoChecksum) {
+ CallContext.register(CallContext.current(),
ApiCommandResourceType.Iso);
+ String isoName = String.format("%s-Kubernetes-Binaries-ISO",
versionName);
+ GetUploadParamsForIsoCmd uploadIso = new GetUploadParamsForIsoCmd();
+ uploadIso = ComponentContext.inject(uploadIso);
+ uploadIso.setName(isoName);
+ uploadIso.setPublicIso(true);
+ if (zoneId != null) {
+ uploadIso.setZoneId(zoneId);
Review Comment:
zoneId - seems to be a mandatory param for upload iso, so I wonder if this
could cause some failure if upload iso is done by a user / dom admin
considering
https://github.com/apache/cloudstack/blob/main/server/src/main/java/com/cloud/template/TemplateAdapterBase.java#L194-L197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
