hsato03 commented on code in PR #10282:
URL: https://github.com/apache/cloudstack/pull/10282#discussion_r1956685974
##########
plugins/storage/volume/adaptive/src/main/java/org/apache/cloudstack/storage/datastore/adapter/ProviderAdapterDiskOffering.java:
##########
@@ -166,7 +166,7 @@ enum State {
}
enum DiskCacheMode {
- NONE("none"), WRITEBACK("writeback"), WRITETHROUGH("writethrough");
+ HYPERVISOR_DEFAULT("hypervisor_default"), NONE("none"),
WRITEBACK("writeback"), WRITETHROUGH("writethrough");
Review Comment:
Yes, this could be refactored to use the `DiskOffering` interface and
`Storage` class enums that are duplicate here, but I think it is better to do
that in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
