Pearl1594 commented on code in PR #9666:
URL: https://github.com/apache/cloudstack/pull/9666#discussion_r1972765171
##########
plugins/backup/nas/src/main/java/org/apache/cloudstack/backup/NASBackupProvider.java:
##########
@@ -373,8 +375,12 @@ public Map<VirtualMachine, Backup.Metric>
getBackupMetrics(Long zoneId, List<Vir
Long vmBackupSize = 0L;
Long vmBackupProtectedSize = 0L;
for (final Backup backup: backupDao.listByVmId(null, vm.getId())) {
- vmBackupSize += backup.getSize();
- vmBackupProtectedSize += backup.getProtectedSize();
+ if (Objects.nonNull(backup.getSize())) {
Review Comment:
I am not sure - but just added a defensive check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
