DaanHoogland commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2705946027
@Dav-11 , few considerations It would seem to me that you would want to overload the VPN APIs with WG specific versions adding the two parameters to them (this would only be valid for create and update btw). If you add them to the generic APIs would you consider those optional and how would they, or their absense be treated in the service? What is the benefit of an object in the parameters in your view? It seems to me there are two that are only going to be used twice. For this to be a profitable design choice we would need to make them generic to be reused in other integrations, I think. regards, hope this doesn't discourage you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
