DaanHoogland commented on issue #10088:
URL: https://github.com/apache/cloudstack/issues/10088#issuecomment-2717577627

   > > > [@weizhouapache](https://github.com/weizhouapache) so does this mean 
this will be removed from healthchecks in the next CS Release?
   > > > Theres no need to hack scripts or change global settings on my side, 
right?
   > > 
   > > 
   > > No [@btzq](https://github.com/btzq) , we will need to pass a flag to the 
healthcheck script in situations where these checks need to be skipped. It 
would not be prudent to skip those unconditionally. Agree 
[@weizhouapache](https://github.com/weizhouapache) ?
   > 
   > it is a bit complicated, as the services are not monitored by health check 
scripts.
   > 
   > services are saved at /etc/monitor.conf in the python script 
`/root/monitorServices.py`, it always check all services in /etc/monitor.conf 
we need to update `/etc/monitor.conf`, or update `/root/monitorServices.py` to 
be able to exclude the check on some services.
   
   I think adding a parameter to indicate what needs to be excluded seems best. 
The alternative, editing the conf or script before running, can work as well, 
but seems more clunky as it then will have to be edited on every add or delete 
tier, to make sure the right checks are done/skipped. I think it is better to 
keep the decision as close to the source of truth (orchestration/DB) as 
possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to