JoaoJandre commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2758915926
Hi, @slavkap I've reproduced your tests and have fixed the issues: 1. On the first case, when copying the snapshot back from the second zone, the original snapshot (which was marked as hidden) would be removed from the DB and a new one would be copied. This would cause a bug were the snapshot chain would be broken. Now, if we want to copy a snapshot to a datastore where we already have it hidden, it will simply go back to ready. 2. On the second case, the parent snapshot was not being properly marked as end_of_chain because there were changes to the snapshot destroy workflow that I did not take into account when merging with main. Now the parent will be correctly marked as end_of_chain and the next snapshot will be full. 3. Regarding the third case, it seems like the issue is in your test env. In my env, using two KVM clusters in different zones each with its cluster-wide file-based primary storage, the creation worked (both on main and on my PR). If I changed the cluster on the second zone to a Xen cluster, and thus changed the storage hypervisor to be Xen as well, then I was able to reproduce your error, both on main and on my PR. Which I think is expected. Could you check if your concerns are met? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
