rohityadavcloud commented on code in PR #10630:
URL: https://github.com/apache/cloudstack/pull/10630#discussion_r2018170524
##########
utils/src/main/java/org/apache/cloudstack/utils/redfish/RedfishClient.java:
##########
@@ -265,12 +265,12 @@ private String getRequestPathForCommand(RedfishCmdType
cmd, String resourceId) {
if (StringUtils.isBlank(resourceId)) {
throw new RedfishException(String.format("Command '%s'
requires a valid resource ID '%s'.", cmd, resourceId));
}
- return String.format("%s%s", SYSTEMS_URL_PATH, resourceId);
Review Comment:
No that's not what I meant - if for the basic discovery of the endpoint, a
trailing slash isn't passed some systems could fail (hypothetically, I'm just
asking). I couldn't return with the `/` as it breaks the base case per Kiran's
findings (if I understood them right)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
