nvazquez commented on code in PR #10647:
URL: https://github.com/apache/cloudstack/pull/10647#discussion_r2026475389
##########
vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/DatacenterMO.java:
##########
@@ -82,6 +82,49 @@ public VirtualMachineMO findVm(String vmName) throws
Exception {
List<ObjectContent> ocs = getVmProperties(new String[] {"name",
instanceNameCustomField});
return HypervisorHostHelper.findVmFromObjectContent(_context,
ocs.toArray(new ObjectContent[0]), vmName, instanceNameCustomField);
}
+ public VirtualMachineMO findVm2(String vmName) throws Exception {
Review Comment:
Can we rename the `findVm` method to something similar to
`findVmThroughPropertiesEx` and rename this `findVm2` method to `findVm`? This
way we can redirect all the existing usages of the method to it. Then we could
invoke `findVmThroughPropertiesEx` to the listUnmanagedInstances execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
