shwstppr commented on code in PR #10485:
URL: https://github.com/apache/cloudstack/pull/10485#discussion_r2032722859
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade42010to42100.java:
##########
@@ -98,6 +100,8 @@ protected void migrateConfigurationScopeToBitmask(Connection
conn) {
migrateExistingConfigurationScopeValues(conn);
DbUpgradeUtils.dropTableColumnsIfExist(conn, "configuration",
List.of("scope"));
DbUpgradeUtils.changeTableColumnIfNotExist(conn, "configuration",
"new_scope", "scope", "BIGINT NOT NULL DEFAULT 0 COMMENT 'Bitmask for scope(s)
of this parameter'");
+ ConfigurationDao dao = new ConfigurationDaoImpl();
+ dao.markForColumnsRefresh();
Review Comment:
@abh1sar thanks for checking. No ideas at the moment
Only improvement suggestion I've at the moment is making
`markForColumnsRefresh` static so we don't need to create new instance and as
it only toggles a static member of the class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
