winterhazel opened a new pull request, #10699: URL: https://github.com/apache/cloudstack/pull/10699
### Description Depending on the Management Server's Locale, `listVirtualMachinesUsageHistory` may return decimal values separated by a comma in the `cpuused` field; however, the UI expects that this decimal is separated by a dot. In this situation, the metrics page will not show the CPU utilization graph properly (see #10672). This PR fixes this issue. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? 0. Initially, my Locale was set to English 1. I left a VM running for some time, and left the MS collecting utilization metrics 2. I accessed the VM's metrics page, and verified that the graphs were shown properly 3. I changed my MS's Locale to Italian 4. I accessed the VM's metrics page Before the patch, the CPU utilization graph would not be shown properly in step 4 because the decimal value in `cpuused` was being separated with a comma. After the patch, the graphs are shown properly because the value always gets separated with a dot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
