DaanHoogland commented on issue #10687: URL: https://github.com/apache/cloudstack/issues/10687#issuecomment-2804174489
@winterhazel , I noticed a small issue in your solution that I want to discuss. Not sure if this is the place but let me start here at least. What happens in your solution is that for all CREATE events a remove is forced if a DESTROY event is found for the same network. I think the issue is actually that CREATE events are created on implementation as well, which should be a separate type of event. I am not sure how harmfull this is but we are now hiding the bug instead of solving it. If you look at for instance VMs, these can have a sequence of events like, `CREATE, START, STOP, START, STOP, DESTROY`. Networks now would have `CREATE, CREATE, CREATE, DESTROY` for the same type of actions. One would expect `CREATE, IMPLEMENT, STOP, IMPLEMENT, STOP, DESTROY` All that said, I am not against backporting your fix. I think in the network case, usage might not require the specifics of implement, though organisations with strict resource billing would. future work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
