harikrishna-patnala commented on PR #10265: URL: https://github.com/apache/cloudstack/pull/10265#issuecomment-2809078375
I've done some review/testing and discussed with Suresh, following are the findings. There are 3 forms where we are using "quiescevm" 1. For a stopped VM - "Take Instance volume Snapshot" 2. For a volume - "Take Snapshot" 3. For a running VM - "Take Instance Snapshot" For 1 and 2, as @sureshanaparti said it is controlled by "quiescevm" param in the volume response. I see that it has made it consistent with this PR. Though there is another bug like @Rubueno mentioned, the value of "quiescevm" is not honored in the API. For 3, "Take Instance Snapshot" "quiescevm" is there by default. May be we can check for which hypervisors it is supported and keep only for those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
