deajan commented on issue #10727:
URL: https://github.com/apache/cloudstack/issues/10727#issuecomment-2809272452
Sorry, as I said, at one moment, I think I have mixed both while doing tests
creating/deleting bridges to find what the issue is.
For instance, br_npf has eno2 as slave interface, br_bgp0 has a vxlan as
slave interface.
So basically the test to see whether there is `eth*, bond*, team*, vlan*,
em*, p*p*, ens*, eno*, enp*, or enx*` in
`/sys/devices/virtual/net/${bridge}/brif` is not sufficient.
I would change that check to report successful if at least one slave
different than "vnet*" "or "vmbr*" is present (so we outrule running VM
interfaces from uplinks).
This would allow to have bridge slaves interfaces being VXLan, GRETAP,
Geneve or whatever fancy interfaces someone would like to use. It would also
allow Cloudstack to be future proof if someday a new ethernet driver naming
comes out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
