weizhouapache commented on PR #10140:
URL: https://github.com/apache/cloudstack/pull/10140#issuecomment-2812198952
> Thanks @weizhouapache
>
> > * for vm created from ISO, the root volume uses diskofferingId ,
deviceId should be 0 I think.
>
> I tested this. The root volume is being assigned deviceId 0 for both
template and iso.
>
> > * for vm created with multiple data disks, it uses
`datadiskofferinglist`, but deviceId of volumes are not set in
dataDiskOfferingInfo.
>
> deviceIds are set here
>
> ```
> public List<DiskOfferingInfo> getDataDiskOfferingListFromBackup(Backup
backup) {
> ...
> diskOfferingInfoList.add(new DiskOfferingInfo(diskOffering, size,
minIops, maxIops, deviceId));
> ```
>
> Please let me know if this sounds ok.
thanks @abh1sar
good to know it
About the deviceId of datadiskoffering
```
dataDiskOfferingInfo.setDeviceId(1L);
```
should it be 0 if the vm is created from ISO ?
this is not a valid question if we do not support backup actions for vm from
ISO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
