sureshanaparti commented on code in PR #10560:
URL: https://github.com/apache/cloudstack/pull/10560#discussion_r2053576145
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -2862,6 +2869,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd)
throws ResourceUnavailableEx
}
} else {
if (MapUtils.isNotEmpty(details)) {
+ // error out if lease related keys are passed in details
+ if
(details.containsKey(VmDetailConstants.INSTANCE_LEASE_EXECUTION)
+ ||
details.containsKey(VmDetailConstants.INSTANCE_LEASE_EXPIRY_DATE)
+ ||
details.containsKey(VmDetailConstants.INSTANCE_LEASE_EXPIRY_ACTION)) {
+ throw new InvalidParameterValueException("'lease*' should
not be included in details as key");
Review Comment:
```suggestion
throw new InvalidParameterValueException("lease
parameters should not be included in details as key");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
