sureshanaparti commented on code in PR #10265: URL: https://github.com/apache/cloudstack/pull/10265#discussion_r2055651682
########## engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/StorageVMSnapshotStrategy.java: ########## @@ -449,14 +454,14 @@ protected SnapshotInfo createDiskSnapshot(VMSnapshot vmSnapshot, List<SnapshotIn return snapshotInfo; } - protected CreateSnapshotPayload setPayload(VolumeInfo vol, SnapshotVO snapshotCreate) { + protected CreateSnapshotPayload setPayload(VolumeInfo vol, SnapshotVO snapshotCreate, boolean quiescevm) { CreateSnapshotPayload payload = new CreateSnapshotPayload(); payload.setSnapshotId(snapshotCreate.getId()); payload.setSnapshotPolicyId(SnapshotVO.MANUAL_POLICY_ID); payload.setLocationType(snapshotCreate.getLocationType()); payload.setAccount(accountService.getAccount(vol.getAccountId())); payload.setAsyncBackup(false); - payload.setQuiescevm(false); + payload.setQuiescevm(quiescevm); Review Comment: It is passed with the payload (as send in the API cmd) in the snapshotInfo, the underlying storage (if supports) would make use of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org