weizhouapache commented on PR #10725: URL: https://github.com/apache/cloudstack/pull/10725#issuecomment-2827975970
> > > looks good, but one question: what would be the significance of `allowed`? > > > > > > have you checked #10193 ? @DaanHoogland > > yes, `allowed` stays in but is removed from the condition. Isn’t the significance now just `isRootAdmin`? (genuine question!) some fields (xenserver tools version) are only allowed for root admin. this "direct download" is allowed for regular users, so `allowed` has been removed in #10193 the code could be optimized, which is not in the scope of this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
