winterhazel commented on issue #10697: URL: https://github.com/apache/cloudstack/issues/10697#issuecomment-2829166335
@rajujith yes, we have the NIC's ID in usage records for this type; thus, the `listUsageRecords` can be adapted to obtain `isDefault` from the NIC instead to retain the "same" response. However, there's also external integrations that query the database directly. Changing what this column represents could break the integrations that expect it to contain a 0/1 indicating whether a NIC is the default one. Honestly, I do not know any specific external integration that consumes the usage records directly from the database instead of consuming from the API, but I would not consider it as a scenario that does not exist, because this approach has been suggested some times before: https://www.shapeblue.com/cloudstack-usage-service-deep-dive/ https://www.slideshare.net/slideshow/dag-sonstebo-cloudstack-usage-service/115784267 http://events17.linuxfoundation.org/sites/events/files/slides/CCCNA14%20presentation.pdf As I said, I can not pinpoint an external solution that would break due to this, so maybe I'm being unnecessarily concerned, but I think it would be good to consider the impact this change could have before introducing it. I personally think that it's just not necessary or beneficial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
