sureshanaparti commented on code in PR #10770:
URL: https://github.com/apache/cloudstack/pull/10770#discussion_r2059657302
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##########
@@ -1615,26 +1631,81 @@ public List<UnmanagedInstanceTO>
listVMsInDatacenter(ListVmwareDcVmsCmd cmd) {
username = vmwareDc.getUser();
password = vmwareDc.getPassword();
}
+ VcenterData vmwaredc = new VcenterData(vcenter, datacenterName,
username, password);
+ return vmwaredc;
+ }
+
+ private static VmwareContext getVmwareContext(String vcenter, String
username, String password) throws Exception {
+ s_logger.debug(String.format("Connecting to the VMware vCenter %s",
vcenter));
+ String serviceUrl = String.format("https://%s/sdk/vimService";,
vcenter);
+ VmwareClient vimClient = new VmwareClient(vcenter);
+ vimClient.connect(serviceUrl, username, password);
+ return new VmwareContext(vimClient, vcenter);
+ }
+
+ @Override
+ public List<UnmanagedInstanceTO> listVMsInDatacenter(ListVmwareDcVmsCmd
cmd) {
+ VcenterData vmwareDC = getVcenterData(cmd);
+ String vcenter = vmwareDC.vcenter;
+ String username = vmwareDC.username;
+ String password = vmwareDC.password;
+ String datacenterName = vmwareDC.datacenterName;
+ String keyword = cmd.getKeyword();
+ String esxiHostName = cmd.getHostName();
try {
- s_logger.debug(String.format("Connecting to the VMware datacenter
%s at vCenter %s to retrieve VMs",
- datacenterName, vcenter));
- String serviceUrl = String.format("https://%s/sdk/vimService";,
vcenter);
- VmwareClient vimClient = new VmwareClient(vcenter);
- vimClient.connect(serviceUrl, username, password);
- VmwareContext context = new VmwareContext(vimClient, vcenter);
-
- DatacenterMO dcMo = new DatacenterMO(context, datacenterName);
- ManagedObjectReference dcMor = dcMo.getMor();
- if (dcMor == null) {
- String msg = String.format("Unable to find VMware datacenter
%s in vCenter %s",
- datacenterName, vcenter);
- s_logger.error(msg);
- throw new InvalidParameterValueException(msg);
+ VmwareContext context = getVmwareContext(vcenter, username,
password);
+ DatacenterMO dcMo = getDatacenterMO(context, vcenter,
datacenterName);
Review Comment:
should check for dcMo null (in case wrong datacenter name)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
