sureshanaparti commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2841326199
> @sureshanaparti I believe that this has already been extensively tested by @winterhazel, see [#9270 (review)](https://github.com/apache/cloudstack/pull/9270#pullrequestreview-2242776880), [#9270 (review)](https://github.com/apache/cloudstack/pull/9270#pullrequestreview-2670999035) and [#9270 (comment)](https://github.com/apache/cloudstack/pull/9270#issuecomment-2737483411). Also @slavkap has done a lot of testing, see [#9270 (comment)](https://github.com/apache/cloudstack/pull/9270#discussion_r1728856189), [#9270 (comment)](https://github.com/apache/cloudstack/pull/9270#discussion_r1740689799) and [#9270 (comment)](https://github.com/apache/cloudstack/pull/9270#issuecomment-2348820998). Not to mention the tests you have reported. At this point what tests are left to do? > > You are welcome to test it again if you'd like, but I don't see a reason to mark the PR as "needs-testing". Agree @JoaoJandre, it was extensively tested by @winterhazel, @slavkap and me, also, various distros are covered - Ubuntu 24.04, Oracle Linux 9 (@winterhazel), Rocky Linux 8.9 (@slavkap), Alma Linux 8.4 (@sureshanaparti). However, I don't see any upgrade tests done (in case any earlier builds have snapshots taken with old / non-incremental approach and behavior of these snapshots to be validated in the upgraded build with incremental snapshots disabled/enabled - so that there wouldn't be any issues post upgrade). Marked it "needs-testing" for some upgrade tests. @winterhazel, @slavkap, @JoaoJandre Anyone covered upgrade tests as well, please update. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
