shwstppr commented on code in PR #10544:
URL: https://github.com/apache/cloudstack/pull/10544#discussion_r2075021085
##########
server/src/main/java/com/cloud/alert/AlertManagerImpl.java:
##########
@@ -773,6 +767,27 @@ public void sendAlert(AlertType alertType, long
dataCenterId, Long podId, Long c
}
+ @Nullable
+ private AlertVO createAlertForTrivialAlertType(AlertType alertType, long
dataCenterId, Long podId, Long clusterId) {
Review Comment:
`create` sounds a bit off since we get the alert entry from DB
##########
server/src/main/java/com/cloud/alert/AlertManagerImpl.java:
##########
@@ -773,6 +767,27 @@ public void sendAlert(AlertType alertType, long
dataCenterId, Long podId, Long c
}
+ @Nullable
+ private AlertVO createAlertForTrivialAlertType(AlertType alertType, long
dataCenterId, Long podId, Long clusterId) {
+ AlertVO alert = null;
+ List<AlertType> alerts = Arrays.asList(AlertType.ALERT_TYPE_HOST
Review Comment:
should we define this list in the class itself to allow it be created only
once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
