alexandru-bagu commented on PR #10641: URL: https://github.com/apache/cloudstack/pull/10641#issuecomment-2873830557
Daan, #10431 handles kvm. This PR properly handles IPs detected using vmtools for VMware. This bit should be merged either way. What I leave up for discussion is the case where the `GetVmIpAddressCommand` returns false or true with a null ip. In my opinion, if the command returns false (as in there was an error) the IP should not be released - basically the code I wrote in `server/src/main/java/com/cloud/vm/UserVmManagerImpl.java`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
