abh1sar opened a new pull request, #10856:
URL: https://github.com/apache/cloudstack/pull/10856

   ### Description
   
   This PR fixes some inconsistencies in object names and messages.
   
   #### ACL Lists
   1. Replace ACL Lists with ACLs as Access Control List Lists doesn't make 
sense
   2. Replace Add ACL with Add ACL rule wherever a rule is being added
   
   Before:
   <img width="1751" alt="Screenshot 2025-05-13 at 2 01 19 PM" 
src="https://github.com/user-attachments/assets/35bfba33-3903-4533-9b16-9380d47a1925";
 />
   After:
   <img width="1751" alt="Screenshot 2025-05-13 at 2 01 31 PM" 
src="https://github.com/user-attachments/assets/3d7ff791-a3f8-422c-9644-c010ba328f8d";
 />
   Before:
   <img width="1751" alt="Screenshot 2025-05-13 at 2 03 00 PM" 
src="https://github.com/user-attachments/assets/edb169b9-6c49-4184-bc78-9bda52aa242b";
 />
   After:
   <img width="1751" alt="Screenshot 2025-05-13 at 2 03 11 PM" 
src="https://github.com/user-attachments/assets/1693c032-6c97-4c11-9ac2-ea547eb8ea9c";
 />
   
   
   #### User data
   1. Following industry conventions, User data should be written as two words
   2. The term "User Data" used in the main menu creates some confusion, 
whether it is singular or plural. So renamed it to "User Data Library" where 
users can register new User Data.
   3. User data should not be followed by "a"
   
   Before:
   <img width="1325" alt="Screenshot 2025-05-13 at 2 04 42 PM" 
src="https://github.com/user-attachments/assets/fdc68a24-9a36-4afe-9021-8b986ac089c4";
 />
   After:
   <img width="1325" alt="Screenshot 2025-05-13 at 2 05 04 PM" 
src="https://github.com/user-attachments/assets/8f3fbbfa-eae5-4c36-9eee-3e1583a28e75";
 />
   Before:
   <img width="511" alt="Screenshot 2025-05-13 at 2 06 55 PM" 
src="https://github.com/user-attachments/assets/e87751db-3821-4d4e-94fa-132b0ee45f78";
 />
   After:
   <img width="511" alt="Screenshot 2025-05-13 at 2 07 21 PM" 
src="https://github.com/user-attachments/assets/49906951-9073-4a01-9661-187de12650a8";
 />
   
   #### Use Title Case in main menu and create new * buttons
   Before:
   <img width="254" alt="Screenshot 2025-05-13 at 2 09 37 PM" 
src="https://github.com/user-attachments/assets/58479636-9557-497b-92a3-0b6a3328132b";
 />
   <img width="252" alt="Screenshot 2025-05-13 at 2 10 05 PM" 
src="https://github.com/user-attachments/assets/8dda711b-b05e-47a8-ae6a-760522008d30";
 />
   After:
   <img width="252" alt="Screenshot 2025-05-13 at 2 14 08 PM" 
src="https://github.com/user-attachments/assets/6aea4b28-e9ec-457d-b9dc-7605f46d7122";
 />
   
   <img width="252" alt="Screenshot 2025-05-13 at 2 13 36 PM" 
src="https://github.com/user-attachments/assets/8aafddaf-48a8-4952-b33b-4c9666435937";
 />
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally 
changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- 
******************************************************************************* 
-->
   <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE 
DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- 
******************************************************************************* 
-->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to 
-->
   
   #### How did you try to break this feature and the system with this change?
   
   <!-- see how your change affects other areas of the code, etc. -->
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) 
document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to