slavkap commented on PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2876845315
I also want to thank the people involved with this PR, but I also want to
note that the way it was merged was not correct.
I expected:
- The results of these [test
cases](https://github.com/apache/cloudstack/pull/9270#issuecomment-2751571735)
after their fix
- To be tested by more people because this feature affects multiple parties
- I haven’t tested it extensively with the StorPool plugin, and I guess
there haven’t been any tests done with Linstor, PowerFlex, etc. (because most
of the changes are in the main functionality for snapshots)
- When someone approves a PR, there should be a good enough description of
the reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
