julien-vaz opened a new pull request, #10892:
URL: https://github.com/apache/cloudstack/pull/10892

   Consider Quota settings during processing
   
   ### Description
   
   Currently, when using the Quota plugin, it is possible to enable/disable the 
plugin specifically in the account settings. However, even if the plugin is 
disabled for the account, the setting is not considered because the Quota 
manager is failing to get its value, so that the account's Quota balance is 
always processed. This PR fixes this behavior.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   1. A account was created and, before the Usage job was run, the Quota plugin 
was disabled for the account. It was attested via GUI and logs that the account 
didn't appear in Quota and it wasn't even processed.
   2. Another account was created with the Quota plugin enabled. After the 
Usage job was run once and the Quota was processed for the account, the Quota 
plugin was disabled and on the second run it was attested that the credit was 
not decremented. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to