DaanHoogland commented on PR #10504:
URL: https://github.com/apache/cloudstack/pull/10504#issuecomment-2965296449

   > Thank You for the suggestions @DaanHoogland
   > 
   > 1. The other locations where sleep() is being called is in 
non-synchronised blocks, I think it is not good idea to replace those sleep() 
calls with wait(). But in this case sleep() is inside a synchronised block, 
there is no problem here. If you want I can write a utility method wrapping 
wait() call inside a try/catch block and use this method here and maybe use the 
method in future for sleep() calls (if written in synchronised blocks).
   
   that makes sense @sroopsai , A utility method that takes a timeout value and 
a set of log parameters would be great. Either in this PR or in a aseparate one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to