bernardodemarco commented on code in PR #9102: URL: https://github.com/apache/cloudstack/pull/9102#discussion_r2150537587
########## ui/src/views/compute/CreateKubernetesCluster.vue: ########## @@ -180,6 +199,192 @@ </a-select-option> </a-select> </a-form-item> + + <!-- Advanced configurations --> + <a-form-item name="advancedmode" ref="advancedmode"> + <template #label> + <tooltip-label :title="$t('label.isadvanced')" /> + </template> + <a-switch v-model:checked="form.advancedmode" /> + </a-form-item> + <a-form-item v-if="form.advancedmode" name="controlofferingid" ref="controlofferingid"> + <template #label> + <tooltip-label :title="$t('label.cks.cluster.control.nodes.offeringid')" :tooltip="$t('label.cks.cluster.control.nodes.offeringid')"/> + </template> + <a-select + id="control-offering-selection" + v-model:value="form.controlofferingid" + showSearch + optionFilterProp="label" + :filterOption="(input, option) => { + return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0 + }" + :loading="serviceOfferingLoading" + :placeholder="$t('label.cks.cluster.control.nodes.offeringid')"> + <a-select-option v-for="(opt, optIndex) in serviceOfferings" :key="optIndex" :label="opt.name || opt.description"> + {{ opt.name || opt.description }} + </a-select-option> + </a-select> + </a-form-item> + <a-form-item v-if="form.advancedmode" name="controltemplateid" ref="controltemplateid"> + <template #label> + <tooltip-label :title="$t('label.cks.cluster.control.nodes.templateid')" :tooltip="$t('label.cks.cluster.control.nodes.templateid')"/> + </template> + <a-select + id="control-template-selection" + v-model:value="form.controltemplateid" + showSearch + optionFilterProp="label" + :filterOption="(input, option) => { + return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0 + }" + :loading="serviceOfferingLoading" + :placeholder="$t('label.cks.cluster.control.nodes.templateid')"> + <a-select-option v-for="(opt, optIndex) in templates" :key="optIndex" :label="opt.name || opt.description"> + {{ opt.name || opt.description }} + </a-select-option> + </a-select> + </a-form-item> + <a-form-item v-if="form.advancedmode" name="workerofferingid" ref="workerofferingid"> + <template #label> + <tooltip-label :title="$t('label.cks.cluster.worker.nodes.offeringid')" :tooltip="$t('label.cks.cluster.worker.nodes.offeringid')"/> + </template> + <a-select + id="worker-offering-selection" + v-model:value="form.workerofferingid" + showSearch + optionFilterProp="label" + :filterOption="(input, option) => { + return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0 + }" + :loading="serviceOfferingLoading" + :placeholder="$t('label.cks.cluster.worker.nodes.offeringid')"> + <a-select-option v-for="(opt, optIndex) in serviceOfferings" :key="optIndex" :label="opt.name || opt.description"> + {{ opt.name || opt.description }} + </a-select-option> + </a-select> + </a-form-item> + <a-form-item v-if="form.advancedmode" name="workertemplateid" ref="workertemplateid"> + <template #label> + <tooltip-label :title="$t('label.cks.cluster.worker.nodes.templateid')" :tooltip="$t('label.cks.cluster.worker.nodes.templateid')"/> + </template> + <a-select + id="worker-template-selection" + v-model:value="form.workertemplateid" + showSearch + optionFilterProp="label" + :filterOption="(input, option) => { + return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0 + }" + :loading="serviceOfferingLoading" + :placeholder="$t('label.cks.cluster.worker.nodes.templateid')"> + <a-select-option v-for="(opt, optIndex) in templates" :key="optIndex" :label="opt.name || opt.description"> + {{ opt.name || opt.description }} + </a-select-option> + </a-select> + </a-form-item> + <a-form-item v-if="form.advancedmode" name="etcdnodes" ref="etcdnodes"> + <template #label> + <tooltip-label :title="$t('label.cks.cluster.etcd.nodes')" :tooltip="apiParams.controlnodes.description"/> + </template> + <a-input + v-model:value="form.etcdnodes" + :placeholder="apiParams.controlnodes.description"/> Review Comment: ```suggestion v-model:value="form.etcdnodes" :placeholder="apiParams.etcdnodes.description"/> ``` ########## ui/src/views/compute/CreateKubernetesCluster.vue: ########## @@ -180,6 +199,192 @@ </a-select-option> </a-select> </a-form-item> + + <!-- Advanced configurations --> + <a-form-item name="advancedmode" ref="advancedmode"> + <template #label> + <tooltip-label :title="$t('label.isadvanced')" /> + </template> + <a-switch v-model:checked="form.advancedmode" /> + </a-form-item> + <a-form-item v-if="form.advancedmode" name="controlofferingid" ref="controlofferingid"> + <template #label> + <tooltip-label :title="$t('label.cks.cluster.control.nodes.offeringid')" :tooltip="$t('label.cks.cluster.control.nodes.offeringid')"/> + </template> + <a-select + id="control-offering-selection" + v-model:value="form.controlofferingid" + showSearch + optionFilterProp="label" + :filterOption="(input, option) => { + return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0 + }" + :loading="serviceOfferingLoading" + :placeholder="$t('label.cks.cluster.control.nodes.offeringid')"> + <a-select-option v-for="(opt, optIndex) in serviceOfferings" :key="optIndex" :label="opt.name || opt.description"> + {{ opt.name || opt.description }} + </a-select-option> + </a-select> + </a-form-item> + <a-form-item v-if="form.advancedmode" name="controltemplateid" ref="controltemplateid"> + <template #label> + <tooltip-label :title="$t('label.cks.cluster.control.nodes.templateid')" :tooltip="$t('label.cks.cluster.control.nodes.templateid')"/> + </template> + <a-select + id="control-template-selection" + v-model:value="form.controltemplateid" + showSearch + optionFilterProp="label" + :filterOption="(input, option) => { + return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0 + }" + :loading="serviceOfferingLoading" + :placeholder="$t('label.cks.cluster.control.nodes.templateid')"> + <a-select-option v-for="(opt, optIndex) in templates" :key="optIndex" :label="opt.name || opt.description"> + {{ opt.name || opt.description }} + </a-select-option> + </a-select> + </a-form-item> + <a-form-item v-if="form.advancedmode" name="workerofferingid" ref="workerofferingid"> + <template #label> + <tooltip-label :title="$t('label.cks.cluster.worker.nodes.offeringid')" :tooltip="$t('label.cks.cluster.worker.nodes.offeringid')"/> + </template> + <a-select + id="worker-offering-selection" + v-model:value="form.workerofferingid" + showSearch + optionFilterProp="label" + :filterOption="(input, option) => { + return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0 + }" + :loading="serviceOfferingLoading" + :placeholder="$t('label.cks.cluster.worker.nodes.offeringid')"> + <a-select-option v-for="(opt, optIndex) in serviceOfferings" :key="optIndex" :label="opt.name || opt.description"> + {{ opt.name || opt.description }} + </a-select-option> + </a-select> + </a-form-item> + <a-form-item v-if="form.advancedmode" name="workertemplateid" ref="workertemplateid"> + <template #label> + <tooltip-label :title="$t('label.cks.cluster.worker.nodes.templateid')" :tooltip="$t('label.cks.cluster.worker.nodes.templateid')"/> + </template> + <a-select + id="worker-template-selection" + v-model:value="form.workertemplateid" + showSearch + optionFilterProp="label" + :filterOption="(input, option) => { + return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0 + }" + :loading="serviceOfferingLoading" + :placeholder="$t('label.cks.cluster.worker.nodes.templateid')"> + <a-select-option v-for="(opt, optIndex) in templates" :key="optIndex" :label="opt.name || opt.description"> + {{ opt.name || opt.description }} + </a-select-option> + </a-select> + </a-form-item> + <a-form-item v-if="form.advancedmode" name="etcdnodes" ref="etcdnodes"> + <template #label> + <tooltip-label :title="$t('label.cks.cluster.etcd.nodes')" :tooltip="apiParams.controlnodes.description"/> Review Comment: ```suggestion <tooltip-label :title="$t('label.cks.cluster.etcd.nodes')" :tooltip="apiParams.etcdnodes.description"/> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org