he1l0world opened a new pull request, #11042:
URL: https://github.com/apache/cloudstack/pull/11042

   ### Description
   
   This PR adds unit test coverage for the `getConfigResources()` method in the 
`ModuleDefinitionSet` class to validate context resource logic. This ensures 
modules are loading the correct Spring context files, including contexts, 
inherited contexts, and overridden contexts.
   
   To improve readability and avoid confusion, some Spring context XML files 
were renamed to match their associated modules more intuitively.
   
   Additionally, a small test refactor was made: the instantiation of 
`ModuleBasedContextFactory` was moved to the top of the test class as a shared 
field, since the factory is stateless and does not need to be recreated for 
each test case
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [X] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   Not applicable
   
   ### How Has This Been Tested?
   Added `testConfigResources()` in `ModuleBasedContextFactoryTest.java` with 
assertions for expected Spring resource files.
   
   
   #### How did you try to break this feature and the system with this change?
   
   - Provided intentionally incorrect module names to verify fallbacks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to