abh1sar commented on code in PR #10140:
URL: https://github.com/apache/cloudstack/pull/10140#discussion_r2225061978
##########
api/src/main/java/org/apache/cloudstack/backup/BackupProvider.java:
##########
@@ -110,9 +111,28 @@ public interface BackupProvider {
/**
* This method should TODO
+ *
* @param restorePoint the restore point to create a backup for
- * @param vm The machine for which to create a backup
- * @param metric the metric object to update with the new backup data
+ * @param vm The machine for which to create a backup
+ */
+ Backup createNewBackupEntryForRestorePoint(Backup.RestorePoint
restorePoint, VirtualMachine vm);
+
+ /**
+ * Returns if the backup provider supports creating new instance from
backup
*/
- Backup createNewBackupEntryForRestorePoint(Backup.RestorePoint
restorePoint, VirtualMachine vm, Backup.Metric metric);
+ boolean supportsInstanceFromBackup();
+
+ /**
+ * Returns the backup storage usage (Used, Total) for a backup provider
+ * @param zoneId the zone for which to return metrics
+ * @return a pair of Used size and Total size for the backup storage
+ */
+ Pair<Long, Long> getBackupStorageStats(Long zoneId);
+
+ /**
+ * Gets the backup storage usage (Used, Total) from the plugin and stores
it in db
+ * @param zoneId the zone for which to return metrics
+ */
+ void syncBackupStorageStats(Long zoneId);
Review Comment:
Please see the reply above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
