nvazquez commented on code in PR #10975:
URL: https://github.com/apache/cloudstack/pull/10975#discussion_r2228162366
##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -1259,6 +1262,12 @@ private UserVm importVirtualMachineInternal(final
UnmanagedInstanceTO unmanagedI
return userVm;
}
+ private void addImportingVMBootTypeAndModeDetails(String bootType, String
bootMode, Map<String, String> allDetails) {
+ if (StringUtils.isNotBlank(bootType) &&
bootType.equalsIgnoreCase("uefi") && StringUtils.isNotBlank(bootMode)) {
Review Comment:
I think the deployasis check doesn't apply here, since Vmware to KVM
migrations won't have that boolean enabled then converted VMs will never retain
the boot mode and type. In case the VM is deploy as is then the boot mode and
type will be preserved.
For the bootMode I think we do need to check if its not blank as that is the
value we are adding as detail for the converted VM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
