abh1sar commented on code in PR #10140: URL: https://github.com/apache/cloudstack/pull/10140#discussion_r2228996628
########## server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java: ########## @@ -599,10 +705,19 @@ public boolean createBackup(final Long vmId, final Long scheduleId) throws Resou throw new CloudRuntimeException("VM backup offering not found"); } + final BackupProvider backupProvider = getBackupProvider(offering.getProvider()); + if (offering == null) { + throw new CloudRuntimeException("VM backup provider not found for the offering"); + } Review Comment: it should be `if (backup_provider == null) {` here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org