shrikantjoshi-hpe opened a new pull request, #11298: URL: https://github.com/apache/cloudstack/pull/11298
### Description Enhanced the Primera storage adapter's volume copy functionality to implement copy method selection based on volume size requirements. The adapter now automatically determines whether to use online copy (fast clone) or offline copy to optimize performance and resource utilization. Key Changes: • Added automatic copy method detection based on source and target volume size comparison • Implemented online copy for same-size volumes (immediate cloning with deduplication) • Implemented offline copy for volume resize operations (background task with high priority) • Enhanced logging with detailed copy method selection rationale and operation progress • Added proper task monitoring and completion handling for offline copy operations • Optimized copy parameters (provisioning type settings) ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [x] Minor - [ ] Trivial ### Screenshots (if appropriate): N/A - Backend storage adapter enhancement ### How Has This Been Tested? Copy Operation Test Scenarios: 1. Same-Size Volume Copy (Online Copy Path): • Verified fast cloning with immediate completion • Confirmed deduplication and compression enabled 2. Different-Size Volume Copy (Offline Copy Path): • Tested volume resize during copy operations • Verified background task creation with high priority • Confirmed proper target volume pre-creation with correct size • Validated task completion monitoring and timeout handling 3. Copy Method Selection Logic: • Tested size comparison logic (newSize vs sourceSize) • Verified online copy selection when sizes match exactly • Confirmed offline copy selection when sizes differ 4. Copy Configuration Validation: • Verified online copy parameters • Verified offline copy parameters, background execution • Tested proper request parameter assignment 5. Error Handling and Logging • Verified detailed logging for copy method selection decisions #### How did you try to break this feature and the system with this change? Copy Operation Stress Testing • Initiated multiple concurrent copy operations to test Primera API limits • Tested copy operations with very large volumes (>100GB) Edge Cases and Boundary Conditions: • Tested with minimum volume sizes Integration Testing: • Tested copy operations within CloudStack volume lifecycle (templates) The enhancement maintains full backward compatibility while providing significant performance improvements for volume copy operations through method selection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
