Copilot commented on code in PR #11315:
URL: https://github.com/apache/cloudstack/pull/11315#discussion_r2238400912
##########
ui/src/views/infra/AddSecondaryStorage.vue:
##########
@@ -295,8 +295,10 @@ export default {
const swiftParams = {
account: values.account,
username: values.username,
- key: values.key,
- storagepolicy: values.storagepolicy
+ key: values.key
+ }
+ if (values.storagepolicy) {
Review Comment:
The condition `if (values.storagepolicy)` will treat empty strings as falsy,
potentially excluding valid but empty storage policies. Consider using a more
explicit check like `if (values.storagepolicy !== undefined &&
values.storagepolicy !== null)` if empty strings are valid values.
```suggestion
if (values.storagepolicy !== undefined && values.storagepolicy !==
null) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
