JoaoJandre commented on code in PR #11313:
URL: https://github.com/apache/cloudstack/pull/11313#discussion_r2239534050
##########
server/src/main/java/com/cloud/api/query/dao/SnapshotJoinDaoImpl.java:
##########
@@ -96,9 +97,27 @@ private void setSnapshotInfoDetailsInResponse(SnapshotJoinVO
snapshot, SnapshotR
} else {
snapshotResponse.setRevertable(snapshotInfo.isRevertable());
snapshotResponse.setPhysicalSize(snapshotInfo.getPhysicalSize());
+
+ boolean showChainSize =
SnapshotManager.snapshotShowChainSize.valueIn(snapshot.getDataCenterId());
+ if (showChainSize && snapshotInfo.getParent() != null) {
+ long chainSize = calculateChainSize(snapshotInfo);
+ snapshotResponse.setChainSize(chainSize);
+ }
}
}
+ private long calculateChainSize(SnapshotInfo snapshotInfo) {
Review Comment:
`snapshot.delta.max` might be changed to a smaller number, this is one way
of having a longer chain size than the configuration. I think we can set a
limit but it should be something like 10 times the chain size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
