Copilot commented on code in PR #11306:
URL: https://github.com/apache/cloudstack/pull/11306#discussion_r2241549232
##########
ui/src/views/compute/CreateAutoScaleVmGroup.vue:
##########
@@ -738,7 +738,7 @@
{{ $t('label.isadvanced') }}
<a-switch v-model:checked="showDetails"
style="margin-left: 10px"/>
</span>
- <div style="margin-top: 15px" v-show="showDetails">
+ <div style="margin-top: 15px" v-if="showDetails">
Review Comment:
[nitpick] Consider using v-show instead of v-if if the advanced settings
section contains heavy components that are expensive to create/destroy. The
v-if directive will completely recreate the DOM elements each time, while
v-show only toggles visibility. However, if the current change fixes the
intended behavior, this may be the correct approach.
```suggestion
<div style="margin-top: 15px" v-show="showDetails">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
