DaanHoogland commented on code in PR #11462:
URL: https://github.com/apache/cloudstack/pull/11462#discussion_r2284860818


##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapConfigurationVO.java:
##########
@@ -36,19 +38,24 @@ public class LdapConfigurationVO implements 
InternalIdentity {
     @Column(name = "id")
     private Long id;
 
+    @Column(name = "uuid")
+    private String uuid;
+
     @Column(name = "port")
     private int port;
 
     @Column(name = "domain_id")
     private Long domainId;
 
     public LdapConfigurationVO() {
+        this.uuid = UUID.randomUUID().toString();
     }
 
     public LdapConfigurationVO(final String hostname, final int port, final 
Long domainId) {
         this.hostname = hostname;
         this.port = port;
         this.domainId = domainId;
+        this.uuid = UUID.randomUUID().toString();

Review Comment:
   shouldn’t this be read from the DB somehow?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to