weizhouapache commented on code in PR #11507:
URL: https://github.com/apache/cloudstack/pull/11507#discussion_r2298061517
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java:
##########
@@ -567,4 +573,22 @@ private void extractCpuModeDef(final Element rootElement){
}
}
}
+
+ private Integer extractVlanFromBridgeName(String bridge) {
+ if (!bridge.startsWith("br")) {
Review Comment:
@abh1sar
do we consider that the bridge name has different format than cloudstack
bridges (brethX-XX) ?
for example, the bridge name is `vmbr1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
