rajujith commented on code in PR #7857:
URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2309309991
##########
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java:
##########
@@ -57,37 +57,37 @@ public class CreateEgressFirewallRuleCmd extends
BaseAsyncCreateCmd implements F
type = CommandType.UUID,
entityType = NetworkResponse.class,
required = true,
- description = "the network id of the port forwarding rule")
+ description = "The network id of the port forwarding rule")
private Long networkId;
@Parameter(name = ApiConstants.PROTOCOL,
type = CommandType.STRING,
required = true,
- description = "the protocol for the firewall rule. Valid values
are TCP/UDP/ICMP.")
+ description = "The protocol for the firewall rule. Valid values
are TCP/UDP/ICMP.")
private String protocol;
- @Parameter(name = ApiConstants.START_PORT, type = CommandType.INTEGER,
description = "the starting port of firewall rule")
+ @Parameter(name = ApiConstants.START_PORT, type = CommandType.INTEGER,
description = "The starting port of firewall rule")
private Integer publicStartPort;
- @Parameter(name = ApiConstants.END_PORT, type = CommandType.INTEGER,
description = "the ending port of firewall rule")
+ @Parameter(name = ApiConstants.END_PORT, type = CommandType.INTEGER,
description = "The ending port of firewall rule")
private Integer publicEndPort;
- @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "the cidr list to forward
traffic from. Multiple entries must be separated by a single comma character
(,).")
+ @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "The cidr list to forward
traffic from. Multiple entries must be separated by a single comma character
(,).")
private List<String> cidrlist;
- @Parameter(name = ApiConstants.DEST_CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "the cidr list to forward
traffic to. Multiple entries must be separated by a single comma character
(,).")
+ @Parameter(name = ApiConstants.DEST_CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "The cidr list to forward
traffic to. Multiple entries must be separated by a single comma character
(,).")
private List<String> destCidrList;
- @Parameter(name = ApiConstants.ICMP_TYPE, type = CommandType.INTEGER,
description = "type of the icmp message being sent")
+ @Parameter(name = ApiConstants.ICMP_TYPE, type = CommandType.INTEGER,
description = "Type of the icmp message being sent")
Review Comment:
ICMP
##########
api/src/main/java/org/apache/cloudstack/api/command/user/firewall/CreateEgressFirewallRuleCmd.java:
##########
@@ -57,37 +57,37 @@ public class CreateEgressFirewallRuleCmd extends
BaseAsyncCreateCmd implements F
type = CommandType.UUID,
entityType = NetworkResponse.class,
required = true,
- description = "the network id of the port forwarding rule")
+ description = "The network id of the port forwarding rule")
private Long networkId;
@Parameter(name = ApiConstants.PROTOCOL,
type = CommandType.STRING,
required = true,
- description = "the protocol for the firewall rule. Valid values
are TCP/UDP/ICMP.")
+ description = "The protocol for the firewall rule. Valid values
are TCP/UDP/ICMP.")
private String protocol;
- @Parameter(name = ApiConstants.START_PORT, type = CommandType.INTEGER,
description = "the starting port of firewall rule")
+ @Parameter(name = ApiConstants.START_PORT, type = CommandType.INTEGER,
description = "The starting port of firewall rule")
private Integer publicStartPort;
- @Parameter(name = ApiConstants.END_PORT, type = CommandType.INTEGER,
description = "the ending port of firewall rule")
+ @Parameter(name = ApiConstants.END_PORT, type = CommandType.INTEGER,
description = "The ending port of firewall rule")
private Integer publicEndPort;
- @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "the cidr list to forward
traffic from. Multiple entries must be separated by a single comma character
(,).")
+ @Parameter(name = ApiConstants.CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "The cidr list to forward
traffic from. Multiple entries must be separated by a single comma character
(,).")
private List<String> cidrlist;
- @Parameter(name = ApiConstants.DEST_CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "the cidr list to forward
traffic to. Multiple entries must be separated by a single comma character
(,).")
+ @Parameter(name = ApiConstants.DEST_CIDR_LIST, type = CommandType.LIST,
collectionType = CommandType.STRING, description = "The cidr list to forward
traffic to. Multiple entries must be separated by a single comma character
(,).")
private List<String> destCidrList;
- @Parameter(name = ApiConstants.ICMP_TYPE, type = CommandType.INTEGER,
description = "type of the icmp message being sent")
+ @Parameter(name = ApiConstants.ICMP_TYPE, type = CommandType.INTEGER,
description = "Type of the icmp message being sent")
private Integer icmpType;
- @Parameter(name = ApiConstants.ICMP_CODE, type = CommandType.INTEGER,
description = "error code for this icmp message")
+ @Parameter(name = ApiConstants.ICMP_CODE, type = CommandType.INTEGER,
description = "Error code for this icmp message")
Review Comment:
ICMP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
