rajujith commented on code in PR #7857:
URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2332128941
##########
api/src/main/java/org/apache/cloudstack/api/response/NicResponse.java:
##########
@@ -31,79 +31,79 @@
public class NicResponse extends BaseResponse {
@SerializedName(ApiConstants.ID)
- @Param(description = "the ID of the nic")
+ @Param(description = "The ID of the NIC")
private String id;
@SerializedName(ApiConstants.NETWORK_ID)
- @Param(description = "the ID of the corresponding network")
+ @Param(description = "The ID of the corresponding Network")
private String networkId;
@SerializedName(ApiConstants.NETWORK_NAME)
- @Param(description = "the name of the corresponding network")
+ @Param(description = "The name of the corresponding Network")
private String networkName;
@SerializedName(ApiConstants.NETMASK)
- @Param(description = "the netmask of the nic")
+ @Param(description = "The netmask of the NIC")
private String netmask;
@SerializedName(ApiConstants.GATEWAY)
- @Param(description = "the gateway of the nic")
+ @Param(description = "The gateway of the NIC")
private String gateway;
@SerializedName(ApiConstants.IP_ADDRESS)
- @Param(description = "the ip address of the nic")
+ @Param(description = "The IP address of the NIC")
private String ipaddress;
@SerializedName(ApiConstants.ISOLATION_URI)
- @Param(description = "the isolation uri of the nic")
+ @Param(description = "The isolation uri of the NIC")
private String isolationUri;
@SerializedName(ApiConstants.BROADCAST_URI)
- @Param(description = "the broadcast uri of the nic")
+ @Param(description = "The broadcast uri of the NIC")
private String broadcastUri;
@SerializedName(ApiConstants.TRAFFIC_TYPE)
- @Param(description = "the traffic type of the nic")
+ @Param(description = "The traffic type of the NIC")
private String trafficType;
@SerializedName(ApiConstants.TYPE)
- @Param(description = "the type of the nic")
+ @Param(description = "The type of the NIC")
private String type;
@SerializedName(ApiConstants.IS_DEFAULT)
- @Param(description = "true if nic is default, false otherwise")
+ @Param(description = "True if NIC is default, false otherwise")
private Boolean isDefault;
@SerializedName(ApiConstants.MAC_ADDRESS)
- @Param(description = "true if nic is default, false otherwise")
+ @Param(description = "True if NIC is default, false otherwise")
private String macAddress;
@SerializedName(ApiConstants.IP6_GATEWAY)
- @Param(description = "the gateway of IPv6 network")
+ @Param(description = "The gateway of IPv6 Network")
private String ip6Gateway;
@SerializedName(ApiConstants.IP6_CIDR)
- @Param(description = "the cidr of IPv6 network")
+ @Param(description = "The CIDR of IPv6 Network")
private String ip6Cidr;
@SerializedName(ApiConstants.IP6_ADDRESS)
- @Param(description = "the IPv6 address of network")
+ @Param(description = "The IPv6 address of Network")
private String ip6Address;
@SerializedName(ApiConstants.SECONDARY_IP)
- @Param(description = "the Secondary ipv4 addr of nic")
+ @Param(description = "The Secondary IPv4 addr of NIC")
private List<NicSecondaryIpResponse> secondaryIps;
@SerializedName(ApiConstants.EXTRA_DHCP_OPTION)
- @Param(description = "the extra dhcp options on the nic", since = "4.11.0")
+ @Param(description = "The extra DHCP options on the NIC", since = "4.11.0")
private List<NicExtraDhcpOptionResponse> extraDhcpOptions;
@SerializedName(ApiConstants.DEVICE_ID)
- @Param(description = "device id for the network when plugged into the
virtual machine", since = "4.4")
+ @Param(description = "Device id for the Network when plugged into the
Instance", since = "4.4")
Review Comment:
'ID'
##########
api/src/main/java/org/apache/cloudstack/api/response/NicResponse.java:
##########
@@ -31,79 +31,79 @@
public class NicResponse extends BaseResponse {
@SerializedName(ApiConstants.ID)
- @Param(description = "the ID of the nic")
+ @Param(description = "The ID of the NIC")
private String id;
@SerializedName(ApiConstants.NETWORK_ID)
- @Param(description = "the ID of the corresponding network")
+ @Param(description = "The ID of the corresponding Network")
private String networkId;
@SerializedName(ApiConstants.NETWORK_NAME)
- @Param(description = "the name of the corresponding network")
+ @Param(description = "The name of the corresponding Network")
private String networkName;
@SerializedName(ApiConstants.NETMASK)
- @Param(description = "the netmask of the nic")
+ @Param(description = "The netmask of the NIC")
private String netmask;
@SerializedName(ApiConstants.GATEWAY)
- @Param(description = "the gateway of the nic")
+ @Param(description = "The gateway of the NIC")
private String gateway;
@SerializedName(ApiConstants.IP_ADDRESS)
- @Param(description = "the ip address of the nic")
+ @Param(description = "The IP address of the NIC")
private String ipaddress;
@SerializedName(ApiConstants.ISOLATION_URI)
- @Param(description = "the isolation uri of the nic")
+ @Param(description = "The isolation uri of the NIC")
private String isolationUri;
@SerializedName(ApiConstants.BROADCAST_URI)
- @Param(description = "the broadcast uri of the nic")
+ @Param(description = "The broadcast uri of the NIC")
private String broadcastUri;
@SerializedName(ApiConstants.TRAFFIC_TYPE)
- @Param(description = "the traffic type of the nic")
+ @Param(description = "The traffic type of the NIC")
private String trafficType;
@SerializedName(ApiConstants.TYPE)
- @Param(description = "the type of the nic")
+ @Param(description = "The type of the NIC")
private String type;
@SerializedName(ApiConstants.IS_DEFAULT)
- @Param(description = "true if nic is default, false otherwise")
+ @Param(description = "True if NIC is default, false otherwise")
private Boolean isDefault;
@SerializedName(ApiConstants.MAC_ADDRESS)
- @Param(description = "true if nic is default, false otherwise")
+ @Param(description = "True if NIC is default, false otherwise")
private String macAddress;
@SerializedName(ApiConstants.IP6_GATEWAY)
- @Param(description = "the gateway of IPv6 network")
+ @Param(description = "The gateway of IPv6 Network")
private String ip6Gateway;
@SerializedName(ApiConstants.IP6_CIDR)
- @Param(description = "the cidr of IPv6 network")
+ @Param(description = "The CIDR of IPv6 Network")
private String ip6Cidr;
@SerializedName(ApiConstants.IP6_ADDRESS)
- @Param(description = "the IPv6 address of network")
+ @Param(description = "The IPv6 address of Network")
private String ip6Address;
@SerializedName(ApiConstants.SECONDARY_IP)
- @Param(description = "the Secondary ipv4 addr of nic")
+ @Param(description = "The Secondary IPv4 addr of NIC")
private List<NicSecondaryIpResponse> secondaryIps;
@SerializedName(ApiConstants.EXTRA_DHCP_OPTION)
- @Param(description = "the extra dhcp options on the nic", since = "4.11.0")
+ @Param(description = "The extra DHCP options on the NIC", since = "4.11.0")
private List<NicExtraDhcpOptionResponse> extraDhcpOptions;
@SerializedName(ApiConstants.DEVICE_ID)
- @Param(description = "device id for the network when plugged into the
virtual machine", since = "4.4")
+ @Param(description = "Device id for the Network when plugged into the
Instance", since = "4.4")
private String deviceId;
@SerializedName(ApiConstants.VIRTUAL_MACHINE_ID)
- @Param(description = "Id of the vm to which the nic belongs")
+ @Param(description = "Id of the Instance to which the NIC belongs")
Review Comment:
'ID'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
