jbampton opened a new pull request, #11651: URL: https://github.com/apache/cloudstack/pull/11651
### Description This PR adds a manual hook that can be used in a full repo clean up on a local machine. See some of my discussion about manual hooks here: refs https://github.com/apache/cloudstack-www/pull/362 So Windows users don't normally have the `chmod` command so this hook can be run by macOS and Linux users when needed. And I have also added this to the CI with a `--hook-stage manual` run so we don't lose coverage. In future we can more manual stage hooks. Some other ASF projects that use the hooks from Lucas-C are Apache Sedona and Apache Airflow: https://github.com/apache/sedona/blob/6029bec540e11b52d0a21819e23db6f4001cec94/.pre-commit-config.yaml#L78 https://github.com/apache/airflow/blob/ec758b7abf189d5027e830d91effa85e17659249/.pre-commit-config.yaml#L50 Also I added Lucas-C hooks to mruby: https://github.com/mruby/mruby/blob/437b47dca7ce8a2bf8a660dbbd920caa33c14794/.pre-commit-config.yaml#L69 <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. --> <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> <!--- ******************************************************************************* --> <!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. --> <!--- PLEASE PUT AN 'X' in only **ONE** box --> <!--- ******************************************************************************* --> ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [X] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [X] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? Ran pre-commit and all the hooks locally <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> #### How did you try to break this feature and the system with this change? <!-- see how your change affects other areas of the code, etc. --> <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
